[BUG] Ability to choose more assets than allowed to (maxAssets)

[yanivshaked]

Bug description
Ability to choose more items than the picker was allowed to (maxAssets).

How to reproduce

• Run the example
• Click Single Asset picker page
• Click WeChat moment (or any other option that is NOT no preview)
• Click on an image to get its preview
• Select it using the "Select" button at the bottom bar
• Swipe right to get to the next image
• Select it
• Keep doing so until you select 10 images
• Click the back button
• You have 10 images selected (when 9 is the maximal number)

Expected behavior
Should not allow selection of more than maxAssets

Screenshots
For example, I selected 12 assets:

Device information

• Device: Android OnePlus 8T
• OS: Android 10
• Package Version: 5.2.1
• Flutter Version: 2.0.5

Additional context
Let me know what are your thoughts on solving this, I can submit a PR.

[AlexV525]

Is this reproducible in other methods?

[yanivshaked]

Reproducible whenever the preview is displayed. Select 9 assets, preview an asset which was not selected and select it => You have 10 assets selected.

[AlexV525]

Then we should add a count check at here maybe.

flutter_wechat_assets_picker/lib/src/delegates/asset_picker_viewer_builder_delegate.dart

Line 123 in cacb7b9

void selectAsset(A entity) {

[yanivshaked]

This also requires transferring maxAssets to AssetPickerViewer.pushToViewer, agree?

[yanivshaked]

Another option, is to use the selectorProvider for selection (so the validation is done in one place), but it is not always transferred to the AssetPickerViewerBuilderDelegate.

[AlexV525]

This also requires transferring maxAssets to AssetPickerViewer.pushToViewer, agree?

This sounds more reasonable.

[yanivshaked]

Merge is done, I'm closing this issue