Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github action #269

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Update github action #269

merged 2 commits into from
Jan 24, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Jan 24, 2024

As this is the most recent workflow version from https://github.com/r-lib/actions/blob/v2/examples/check-standard.yaml

I added working-directory to setup-r-dependencies and check-package to account for the package code not being in the top level directory.

@olivroy olivroy marked this pull request as ready for review January 24, 2024 14:54
@florianhartig
Copy link
Owner

Thanks! Just to know this - was there are problem with the old version, or are there any significant advantages of this one? In the latter case, we should push this to all packages.

@MaximilianPi maybe we should create a central workflow repo for our workflows?

@olivroy
Copy link
Contributor Author

olivroy commented Jan 24, 2024

No problem... yet! But I guess this is future proof, as the old actions likely won't be maintained at some point in the future. These use the pak package which can be used to automatically query any system requirement.

Indeed a good idea to update in packages, as part of the upkeep process!

If you use the default workflow, locally, using usethis::use_github_action("check-standard") gets those. But I made some modifications to adapt to your setting the working directory and add a second check with args: 'c("--no-multiarch", "--no-manual")' as was there before. Also, you test for windows devel, which I kept as well.

          working-directory: BayesianTools
      # second check with different rcmdcheck arguments.
      - uses: r-lib/actions/check-r-package@v2
        with:
          upload-snapshots: true
          working-directory: BayesianTools
          args: 'c("--no-multiarch", "--no-manual")'

      - uses: r-lib/actions/check-r-package@v2
        with:
          upload-snapshots: true
          working-directory: BayesianTools

@florianhartig
Copy link
Owner

Thanks for the explanations! PR Looks good to me, I will merge this!

@florianhartig florianhartig merged commit a379295 into florianhartig:master Jan 24, 2024
6 checks passed
@olivroy olivroy deleted the patch-2 branch January 24, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants