From e690a8f3bf320e5150c66cf926b1e7ff183541a5 Mon Sep 17 00:00:00 2001 From: Nuno Goncalves Date: Fri, 30 Sep 2022 22:52:25 +0100 Subject: [PATCH 1/2] Remove unused crc-check option on dump1090 and faup1090 Signed-off-by: Nuno Goncalves --- dump1090.c | 4 ---- faup1090.c | 1 - 2 files changed, 5 deletions(-) diff --git a/dump1090.c b/dump1090.c index 2b6ab09c5..a22923847 100644 --- a/dump1090.c +++ b/dump1090.c @@ -112,7 +112,6 @@ static void modesInitConfig(void) { // Now initialise things that should not be 0/NULL to their defaults Modes.gain = MODES_DEFAULT_GAIN; Modes.freq = MODES_DEFAULT_FREQ; - Modes.check_crc = 1; Modes.fix_df = 1; Modes.interactive_display_ttl = MODES_INTERACTIVE_DISPLAY_TTL; Modes.json_interval = 1000; @@ -349,7 +348,6 @@ static void showHelp(void) "--no-fix Disable error correction using CRC\n" "--no-fix-df Disable error correction of the DF message field\n" " (reduces CPU requirements)\n" -"--no-crc-check Disable messages with broken CRC (discouraged)\n" "--enable-df24 Enable decoding of DF24 Comm-D ELM messages\n" "--lat Reference/receiver latitude for surface positions\n" "--lon Reference/receiver longitude for surface positions\n" @@ -630,8 +628,6 @@ int main(int argc, char **argv) { Modes.nfix_crc = 0; } else if (!strcmp(argv[j],"--no-fix-df")) { Modes.fix_df = 0; - } else if (!strcmp(argv[j],"--no-crc-check")) { - Modes.check_crc = 0; } else if (!strcmp(argv[j],"--phase-enhance")) { // Ignored, always enabled } else if (!strcmp(argv[j],"--raw")) { diff --git a/faup1090.c b/faup1090.c index 033c7ec00..e4c78a59f 100644 --- a/faup1090.c +++ b/faup1090.c @@ -70,7 +70,6 @@ static void faupInitConfig(void) { // Now initialise things that should not be 0/NULL to their defaults Modes.nfix_crc = 1; - Modes.check_crc = 1; Modes.fix_df = 1; Modes.net = 1; Modes.net_heartbeat_interval = MODES_NET_HEARTBEAT_INTERVAL; From 8f994f94b4a4ced083fb4564a25c3f63afec76dd Mon Sep 17 00:00:00 2001 From: Oliver Jowett Date: Thu, 6 Oct 2022 13:31:29 +0800 Subject: [PATCH 2/2] Still accept --no-crc-check option (but ignore/warn about it) --- dump1090.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dump1090.c b/dump1090.c index a22923847..f7bb3c39b 100644 --- a/dump1090.c +++ b/dump1090.c @@ -628,6 +628,8 @@ int main(int argc, char **argv) { Modes.nfix_crc = 0; } else if (!strcmp(argv[j],"--no-fix-df")) { Modes.fix_df = 0; + } else if (!strcmp(argv[j],"--no-crc-check")) { + fprintf(stderr, "warning: --no-crc-check no longer supported, option ignored (please raise an issue on github if you have a usecase that needs this)\n"); } else if (!strcmp(argv[j],"--phase-enhance")) { // Ignored, always enabled } else if (!strcmp(argv[j],"--raw")) {