Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different CFLAGS for cpu_features #130

Closed
Lalufu opened this issue May 18, 2021 · 1 comment
Closed

Different CFLAGS for cpu_features #130

Lalufu opened this issue May 18, 2021 · 1 comment

Comments

@Lalufu
Copy link

Lalufu commented May 18, 2021

The cpu_features directory uses different CFLAGS/LDFLAGS than the main codebase (coming from Makefile.cpufeatures). What's the reason for this?
My main curiosity is because injecting different CFLAGS into the build process (as RPM building on RH systems does, to enable some safety features) applies to the main process, but not cpu_features.

@mutability
Copy link

Makefile.cpufeatures is basically there to avoid having to run a cmake build of cpu_features and then try to work out where it put everything. The cflags are different because cpu_features is a third-party library with its own compile requirements that don't necessarily line up with the main dump1090 cflags.

The eventual solution (probably) to move everything to cmake, but that is a larger project than I wanted to take on right now. Then you can do whatever you need to do for cmake globally.

For now, if you need to inject additional flags, you'll need to inject them into CPUFEATURES_CFLAGS too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants