Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit log mentions submodules for starch but it's actually directly in the repo #102

Closed
gtjoseph opened this issue Feb 1, 2021 · 2 comments
Closed

Commit log mentions submodules for starch but it's actually directly in the repo #102

gtjoseph opened this issue Feb 1, 2021 · 2 comments

Comments

@gtjoseph
Copy link

gtjoseph commented Feb 1, 2021

Is it supposed to be a submodule and accidentally got checked in or are you going to leave it as checked in code? I do see there's a starch repo now.
@gtjoseph
Copy link
Author

gtjoseph commented Feb 1, 2021

Nevermind. I just saw the following comment further down in the commit...

  • Remove submodules in preparation for importing them directly

@gtjoseph gtjoseph closed this as completed Feb 1, 2021
@mutability
Copy link

Yeah, submodules are sufficiently finicky that I figured it was easier to just inline the code directly; merging updates by hand when needed is not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gtjoseph @mutability