Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the user chose to share "the entire screen" and there is only a single display available, don't make them choose among a choice of 1 #372

Open
nekohayo opened this issue Feb 14, 2022 · 3 comments

Comments

@nekohayo
Copy link

nekohayo commented Feb 14, 2022

If you have only one monitor, as lots of people do (especially if they're on a laptop on the go), when you want to share your screen with Firefox under Wayland, you get this:

1

That dialog's set of two buttons might seem visually misleading to non-technical users, because the "Single window" button has a blue selection highlight around it, so it could be mistaken as being selected (I know we geeks could tell the "Entire screen" button is depressed, but even then that's still a bit confusing).

But then even if you are aiming to share the "entire screen", you still can't immediately share it. You have to click the "Built-in display" thing even though it's the only choice. Once you click "Affichage intégré" ("Built-in display"), you get the working "Share" button (and note that the selection highlight doesn't go away from "Single Window" even then):

2

This feels like an unnecessary step, and an especially confusing one for non-technical users, for which the "Built-in display" and its clickability are not immediately obvious, from what I've seen; it is much more obvious when there is more than 1 choice available (especially since monitors then have device names).

The computer knows I have only one screen to share, so why is it asking me to choose between a possibility of 1? It would be more helpful to give me a preview thumbnail (issue #333) of the whole screen in that spot if you want to fill the space, and if needed it can also show a label above it that says "Your entire screen will be shared: " ...and immediately unlock the Share button when there is no choice to be made anyway?

@jadahl
Copy link
Contributor

jadahl commented Feb 14, 2022

Could you reopen this on https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/? Further development on the screen casting portal will happen there.

@bilelmoussaoui
Copy link
Member

Isn't that handled already by the changes in flatpak/xdg-desktop-portal@ab515cd?

@nekohayo
Copy link
Author

I don't quite understand what session restore is about, isn't that about remembering the last used user choice? In my case I don't want that, I still want to be able to tell the application whether I want to pick an app window or the whole screen, but I want it to not require extra clicks if there's only one "whole screen" to be picked from.

If you think this is a separate issue still, then yeah I could copy-paste it into a gitlab ticket I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants