Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments should be able to customize exports #763

Open
cosimoc opened this issue May 3, 2017 · 4 comments
Open

Deployments should be able to customize exports #763

cosimoc opened this issue May 3, 2017 · 4 comments

Comments

@cosimoc
Copy link
Contributor

cosimoc commented May 3, 2017

In Endless we have some Flatpak applications that export additional files to the operating system -- see e.g. this patch: endlessm/flatpak@c18bf31

That is of course less than ideal, because it requires the build system to ship a forked flatpak to support this.
This sounds like something that would be useful in general, and I'd like to propose two changes:

  • move the export list from build to deploy; at least this would allow not to require a custom flatpak to build those applications that want to export additional files
  • move the export list not to be hardcoded, so that different deployments can customize it without requiring a patch to flatpak

CC @ramcq @erikos

@matthiasclasen
Copy link
Collaborator

The docs for flatpak build-finish say:

   You should review the exported files and the application metadata before creating and
   distributing an application bundle.

Doesn't that hint at the fact that you are expected to not treat the builtin list as gospel, but tweak exports according to your needs ?

I guess there is still an argument to be made that flatpak builder could support this in the manifest in some convenient way.

@cosimoc
Copy link
Contributor Author

cosimoc commented May 4, 2017

@matthiasclasen I am a bit confused; how is one supposed to add to that export list? flatpak-builder will call flatpak build-finish and I don't see how one would be able to change what gets exported.

@alexlarsson
Copy link
Member

I'm currently working on adding a whitelist that is used when deploying. I would love a patch to that to make the set of allowed exports be configured at the site.

However, we can't drop the exports list during build, because we don't want to export all of share/*. I think we need an argument to build-finish for extra directories to export. Would love a patch for that too.

@alexlarsson
Copy link
Member

Here is the whitelist: e8369a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants