Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing an extension doesn't pull in its runtime #4566

Open
mwleeds opened this issue Nov 12, 2021 · 4 comments · May be fixed by #5768
Open

Installing an extension doesn't pull in its runtime #4566

mwleeds opened this issue Nov 12, 2021 · 4 comments · May be fixed by #5768

Comments

@mwleeds
Copy link
Collaborator

mwleeds commented Nov 12, 2021 

$ flatpak --version
1.12.2
$ flatpak install org.freedesktop.Sdk.Extension.ziglang//21.08
(follow prompts)
$ flatpak info -m org.freedesktop.Sdk.Extension.ziglang
[Runtime]
name=org.freedesktop.Sdk.Extension.ziglang
runtime=org.freedesktop.Sdk/x86_64/21.08
sdk=org.freedesktop.Sdk/x86_64/21.08

[ExtensionOf]
ref=runtime/org.freedesktop.Sdk/x86_64/21.08
runtime=org.freedesktop.Sdk/x86_64/21.08

[Build]
built-extensions=org.freedesktop.Sdk.Extension.ziglang.Sources;
$ flatpak run runtime/org.freedesktop.Sdk/x86_64/21.08
error: runtime/org.freedesktop.Sdk/x86_64/21.08 not installed

Perhaps installing an extension should pull in the runtime the extension depends on (taking into account --no-deps/--no-related) because otherwise the extension is pretty useless since you can't run it on its own right?
@eeejay
Copy link
Contributor

eeejay commented Apr 7, 2024 •
edited

Don't know if this is the same issue, but this would be helpful for app extensions too.

This seems wrong, since the GIMP app is not installed:

$ flatpak --user install flathub org.gimp.GIMP.Plugin.Lensfun//2-40
Looking for matches…


        ID                                Branch      Op      Remote      Download
 1. [✓] org.gimp.GIMP.Plugin.Lensfun      2-40        i       flathub     433.2 kB / 601.6 kB

Installation complete.

It should be pulling in org.gimp.GIMP as a dependency. If not by default, at least that should be an option in the add-extension section.

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Apr 7, 2024 •
edited

#4566 (comment)

@eeejay, that is a slightly different issue, considering that this issue appears to specifically relate to runtimes. Either we should modify the title of this issue, or (probably better, for the short term, at least) report an issue for that references this one so that they're linked.

@hfiguiere
Copy link
Collaborator

Don't know if this is the same issue, but this would be helpful for app extensions too.

[...]

It should be pulling in org.gimp.GIMP as a dependency. If not by default, at least that should be an option in the add-extension section.

it's not a dependency at runtime.
For example audio plugins can be used by any app that has the extension point.

The only relationship is that an application can request the extension to be autodownloaded and autoremove. The other is that flatpak, when you want to remove an extension, may tell you it's used by app xyz, like a runtime.

@RokeJulianLockhart
Copy link

#4566 (comment)

@hfiguiere, in which case, does flatpak support the concept of recommended packages, like https://discussion.fedoraproject.org/t/which-kind-of-dependencies-suggested-recommended-does-dnf-install/74111/2 and https://en.opensuse.org/SDB:Zypper_manual#COMMANDS:~:text=the%20package%0Aobsoletes.-,--recommends,-Show%20symbols%20the demonstrate? If so, then it should still be recommended, at least.

eeejay added a commit to eeejay/flatpak that referenced this issue Apr 9, 2024
@eeejay
Add RequireRef to pull in target app of extension
797c2e3 
Also refactored op_get_runtime_ref a bit. If the extension needs to run
an apply-extra script, and it specifies RequireRef, we don't need to
pull in the runtime, just the ref because the ref will pull in the
target's runtime as well.

Fixes flatpak#4566
eeejay added a commit to eeejay/flatpak that referenced this issue Apr 9, 2024
@eeejay
Add RequireRef to pull in target app of extension
f458d4e 
Also refactored op_get_runtime_ref a bit. If the extension needs to run
an apply-extra script, and it specifies RequireRef, we don't need to
pull in the runtime, just the ref because the ref will pull in the
target's runtime as well.

Fixes flatpak#4566
@eeejay eeejay linked a pull request Apr 9, 2024 that will close this issue
Open
eeejay added a commit to eeejay/flatpak that referenced this issue Apr 9, 2024
@eeejay
Add RequireRef to pull in target app of extension
b8abb14 
Also refactored op_get_runtime_ref a bit. If the extension needs to run
an apply-extra script, and it specifies RequireRef, we don't need to
pull in the runtime, just the ref because the ref will pull in the
target's runtime as well.

Fixes flatpak#4566
eeejay added a commit to eeejay/flatpak that referenced this issue Apr 9, 2024
@eeejay
Add RequireRef to pull in target app of extension
59ea5bc 
Also refactored op_get_runtime_ref a bit. If the extension needs to run
an apply-extra script, and it specifies RequireRef, we don't need to
pull in the runtime, just the ref because the ref will pull in the
target's runtime as well.

Fixes flatpak#4566
eeejay added a commit to eeejay/flatpak that referenced this issue Apr 9, 2024
@eeejay
Add RequireRef to pull in target app of extension
58f34d0 
Also refactored op_get_runtime_ref a bit. If the extension needs to run
an apply-extra script, and it specifies RequireRef, we don't need to
pull in the runtime, just the ref because the ref will pull in the
target's runtime as well.

Fixes flatpak#4566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RequireRef to pull in target app of extension eeejay/flatpak
4 participants
@eeejay @hfiguiere @mwleeds @RokeJulianLockhart