Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Report distro name in useragent #5549

Open
2 tasks done
razzeee opened this issue Oct 3, 2023 · 10 comments
Open
2 tasks done

[Feature request]: Report distro name in useragent #5549

razzeee opened this issue Oct 3, 2023 · 10 comments

Comments

@razzeee
Copy link

razzeee commented Oct 3, 2023

Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Suggestion

The user agent already reports flatpak version and ostree version, additionally, reporting the distro would be nice.

I would expect that in the form of something like this:

libostree/2022.2 flatpak/1.12.7 distro/Fedora

or

libostree/2022.2 flatpak/1.12.7 distro/Fedora 39
@nanonyme
Copy link
Contributor

Should this be using os-release format only or arbitrary per-distro specifications as data source?

@razzeee
Copy link
Author

razzeee commented Dec 12, 2023

I'm not sure if I can answer that correctly

@smcv
Copy link
Collaborator

smcv commented Dec 12, 2023

reporting the distro would be nice

Nice for whom, and for what purpose?

@razzeee
Copy link
Author

razzeee commented Dec 12, 2023

I think mostly where we should spend more time on documentation/moving people over to newer flatpak versions etc

So just as a way to know which distros might need help or a reminder to ship newer versions.

@flexagoon
Copy link

I don't think this has much value, since Flatpak is supposed to be a distro-agnosic platform to run apps on.

So just as a way to know which distros might need help or a reminder to ship newer versions.

Do you mean the version of flatpak apps or of the flatpak package itself? If you mean apps, their versions are not related to distros in any way. If you mean flatpak itself, you can already see distros that ship an old version here.

@nanonyme
Copy link
Contributor

nanonyme commented Jan 25, 2024

Do you mean the version of flatpak apps or of the flatpak package itself? If you mean apps, their versions are not related to distros in any way. If you mean flatpak itself, you can already see distros that ship an old version here.

It would definitely provide some value to see actual usage data pinned to said distros and versions. Currently repo maintainers can mostly see which versions of flatpak are still widely used.

@freechelmi
Copy link

That could be very useful indeed to measure how flatpak progress on blocking distro like Ubuntu

@cassidyjames
Copy link

cassidyjames commented Mar 19, 2024

I was approached by a large ISV (one of the top 10 most-downloaded apps from Flathub) asking if we (Flathub) could provide the number of installs/updates on Steam Deck, as they are evaluating increasing their engineering budget around Steam Deck and thus Linux. While I can point them to the stats for total Flathub installs, it would help their higher-ups to be able to show their adoption on Steam Deck so far.

I also agree that it would be helpful to both app developers and Flathub to have a sense of the spread across distributions; e.g. if I as an app developer get a bug report from an Ubuntu LTS user that something isn't working right (e.g. due to a difference in Portals shipped in that version compared to what I'm testing on Fedora Silverblue), it makes a big difference for my prioritization if Ubuntu LTS users make up a large portion of my installs versus it being a one-off or tiny percent of my users affected.

@razzeee
Copy link
Author

razzeee commented Apr 21, 2024

So I went hunting on where to handle this and it seems like it would need to be done here https://github.com/flatpak/flatpak/blob/main/common/flatpak-dir.c#L5393

@rany2
Copy link

rany2 commented Apr 26, 2024

If this issue is resolved it would help me in figuring out why some users are still using the old app id of the Ungoogled Chromium flatpak. I suspect that there are frontends that are ignoring the eol-rebase but I unfortunately cannot easily know the frontends that are at fault without having this metric.

At least right now, I only have the ostree/flatpak versions and these aren't as helpful as the distro name. I don't have a lot to work off to try and raise issues with these frontends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants