Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.unmojang.FjordLauncher #5267

Draft
wants to merge 1 commit into
base: new-pr
Choose a base branch
from

Conversation

evan-goode
Copy link

Please confirm your submission meets all the criteria

  • Please describe your application briefly.

Hello! Fjord Launcher is a libre Minecraft launcher and a soft fork of Prism Launcher that:

  • Reduces dependence on non-free network services
  • Adds support for alternative Minecraft API servers, such as Ely.by
  • Adds back the ability to download FTB modpacks from within the launcher

The Flatpak for Fjord Launcher is almost identical to that of Prism Launcher, which is already on Flathub as org.prismlauncher.PrismLauncher.

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)

I'm using the same permission set used by upstream org.prismlauncher.PrismLauncher.

  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.

I own unmojang.org, but nothing's there yet on the root domain. I run https://drasl.unmojang.org, which at the bottom links to https://github.com/unmojang/drasl.

  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

Again, I'm following upstream Prism Launcher here. The patches seem all related to Wayland quirks.

@hfiguiere
Copy link
Contributor

I'm using the same permission set used by upstream org.prismlauncher.PrismLauncher.

So you can justify them all?

@@ -0,0 +1,29 @@
# org.unmojang.FjordLauncher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no user will every see this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can remove the README. FWIW, if I Google "prismlauncher flatpak", the third result is https://github.com/flathub/org.prismlauncher.PrismLauncher. Obviously that won't be the case if the README is empty, but if the README is there, it could be a good place to put Flatpak-specific installation notes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just clarifying the expectation here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this. automerge is no longer allowed.

@@ -0,0 +1,22 @@
{
"name": "libdecor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libdecor 0.2.2 is in the runtime.

Comment on lines +13 to +14
- --socket=x11
- --socket=wayland
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's either x11 or wayland. Not both.

# Needed for proper Wayland support
- libdecor.json

- name: fjordlauncher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is the main module it should be last.

modules:
- shared-modules/glu/glu-9.json

- name: enhance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be merged with the main module.

@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label May 20, 2024
@evan-goode
Copy link
Author

@hfiguiere @bbhtt thanks for the quick review, I'm going to mark this as a draft for now. I'm going to try and suggest your changes first to upstream's Flatpak, since I want to stay as close to upstream as possible.

@evan-goode evan-goode marked this pull request as draft May 20, 2024 17:14
@bbhtt bbhtt added blocked Pull requests that are blocked on something or won't be accepted in the currrent state work-in-progress Draft PRs and removed blocked Pull requests that are blocked on something or won't be accepted in the currrent state labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-changes Pull request waiting for changes from author work-in-progress Draft PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants