-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add org.unmojang.FjordLauncher #5267
base: new-pr
Are you sure you want to change the base?
Conversation
So you can justify them all? |
@@ -0,0 +1,29 @@ | |||
# org.unmojang.FjordLauncher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no user will every see this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can remove the README. FWIW, if I Google "prismlauncher flatpak", the third result is https://github.com/flathub/org.prismlauncher.PrismLauncher. Obviously that won't be the case if the README is empty, but if the README is there, it could be a good place to put Flatpak-specific installation notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just clarifying the expectation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this. automerge is no longer allowed.
@@ -0,0 +1,22 @@ | |||
{ | |||
"name": "libdecor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libdecor 0.2.2 is in the runtime.
- --socket=x11 | ||
- --socket=wayland |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's either x11 or wayland. Not both.
# Needed for proper Wayland support | ||
- libdecor.json | ||
|
||
- name: fjordlauncher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is the main module it should be last.
modules: | ||
- shared-modules/glu/glu-9.json | ||
|
||
- name: enhance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be merged with the main module.
@hfiguiere @bbhtt thanks for the quick review, I'm going to mark this as a draft for now. I'm going to try and suggest your changes first to upstream's Flatpak, since I want to stay as close to upstream as possible. |
Please confirm your submission meets all the criteria
Hello! Fjord Launcher is a libre Minecraft launcher and a soft fork of Prism Launcher that:
The Flatpak for Fjord Launcher is almost identical to that of Prism Launcher, which is already on Flathub as org.prismlauncher.PrismLauncher.
I'm using the same permission set used by upstream org.prismlauncher.PrismLauncher.
I own unmojang.org, but nothing's there yet on the root domain. I run https://drasl.unmojang.org, which at the bottom links to https://github.com/unmojang/drasl.
Again, I'm following upstream Prism Launcher here. The patches seem all related to Wayland quirks.