Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client configuration content shows in logs #49

Closed
wzooff opened this issue Oct 7, 2021 · 4 comments
Closed

client configuration content shows in logs #49

wzooff opened this issue Oct 7, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@wzooff
Copy link

wzooff commented Oct 7, 2021

Version: 1.7.0
Run args:

ovpn-admin \
  --templates.clientconfig-path=/mnt/setup/client.conf.tpl \
  --easyrsa.path=/mnt/certs \
  --easyrsa.index-path=/mnt/certs/pki/index.txt \
  --listen.port=8080

With provided configuration when you press Download user config button in web ui, ovpn-admin prints full user config with certificates to log(stdout). Even without --verbose and --debug arguments.

Coz credentials is sensitive data, i suppose that it should not be logged or at least only on debug mode

@pashcovich
Copy link
Contributor

please provide additional information and a description of your problem if you have such

@wzooff
Copy link
Author

wzooff commented Oct 7, 2021

@pashcovich i've updated description

@pashcovich pashcovich added the enhancement New feature or request label Oct 7, 2021
@pashcovich
Copy link
Contributor

@wzooff please check version 1.7.3
now client confg render will be shown in the log only if the --verbose flag is present

@wzooff
Copy link
Author

wzooff commented Oct 15, 2021

@pashcovich works as described. Thanks for quick fix

@wzooff wzooff closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants