Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when overwriting footstep #940

Merged
merged 3 commits into from
Jan 10, 2016

Conversation

YutaKojio
Copy link
Contributor

footstepを上書くためにoverwrite_refzmp_queue を呼んだときに,
Autobalancerが出すcogの値が飛ぶバグがあったので,修正しました.

・いままで
abc_cog_vel_before_x

・このPR
abc_cog_vel_after_x

(progn
  (load "package:https://hrpsys_ros_bridge_tutorials/euslisp/samplerobot-interface.l")
  (samplerobot-init)
  (setq *robot* *sr*)
  (send *ri* :angle-vector (send *robot* :angle-vector) 2000)
  (send *ri* :wait-interpolation)
  (send *ri* :start-auto-balancer)
  (send *ri* :start-st)
  (send *ri* :go-velocity 0.1 0 0)
  (unix:sleep 5)
  (send *ri* :go-stop))

@snozawa
Copy link
Contributor

snozawa commented Jan 9, 2016

なるほど
確認してみます。

@k-okada
Copy link
Contributor

k-okada commented Jan 9, 2016

Refer to this link for build results (access rights to CI server needed):
https://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2545/
Test PASSed.

@snozawa
Copy link
Contributor

snozawa commented Jan 9, 2016

これって、overwriteじか、普段の時に、一回updateの回数が多いのかな?

@YutaKojio
Copy link
Contributor Author

overwriteの時にupdateが一回多いです.
overwrite時は同じ制御周期内で,
https://github.com/fkanehiro/hrpsys-base/blob/master/rtc/AutoBalancer/GaitGenerator.cpp#L554

https://github.com/fkanehiro/hrpsys-base/blob/master/rtc/AutoBalancer/GaitGenerator.cpp#L884
で二度updateするために,
overwriteしたときに,1制御周期分飛んだcogが出ていました.
なので,解決策はこのPRか,
overwrite時は
https://github.com/fkanehiro/hrpsys-base/blob/master/rtc/AutoBalancer/GaitGenerator.cpp#L554
を呼ばないようにするのでもいいかもしれないです.

…scontinuity of COG trajectory during footstep overwriting by checking COG too large acc.
@snozawa
Copy link
Contributor

snozawa commented Jan 9, 2016

@YutaKojio
Copy link
Contributor Author

はい.コメント1コメント2のとおり変更,確認します.

@YutaKojio YutaKojio force-pushed the update_overwrite_refzmp_queue branch from 2b8bb47 to 5652d17 Compare January 9, 2016 15:33
@YutaKojio
Copy link
Contributor Author

proc_one関数内で2回以上updateしないように変更しました.
また,手元でtravisが通ることを確認しました.

@snozawa さん
ご確認よろしくお願い致します.

@k-okada
Copy link
Contributor

k-okada commented Jan 9, 2016

Refer to this link for build results (access rights to CI server needed):
https://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2547/
Test PASSed.

@snozawa
Copy link
Contributor

snozawa commented Jan 10, 2016

LGTM.

travisも通ってるようですのでmergeをお願いできますと助かります。

fkanehiro added a commit that referenced this pull request Jan 10, 2016
@fkanehiro fkanehiro merged commit 16fd654 into fkanehiro:master Jan 10, 2016
@YutaKojio YutaKojio deleted the update_overwrite_refzmp_queue branch April 13, 2016 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants