You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The "reset" button for the model config sets all values to the "default" values. However, when if the runner was loaded from a trace, we should probably reset to the values pre-loaded by the trace instead.
To Reproduce
Steps to reproduce the behavior:
Go to the model runner, and tweak some configurations. Run a prompt.
Click view trace
Click "open in model runner..." (yes, you've made a loop 😝 )
Click reset (values from trace will be "lost")
Expected behavior
If a trace was loaded, essentially the config values from the trace should be respected as the "defaults". See addt'l context for caveat(s).
Screenshots
N/A
Desktop (please complete the following information):
N/A
Mobile (please complete the following information):
N/A
Additional context
There is a gotcha here, which is that if the developer truly does want a "blank" Playground with reasonable defaults, how should they get to it? We could do two buttons ("Reset changes" and "Use defaults"). Or...something else?
FWIW, clicking the model again on the LHS will reset to the defaults (i.e. clean playground).
MichaelDoyle
changed the title
[Tooling] Reset button should respect initial model params set from trace
[Dev UI] Reset button should respect initial model params set from trace
Nov 7, 2024
Describe the bug
The "reset" button for the model config sets all values to the "default" values. However, when if the runner was loaded from a trace, we should probably reset to the values pre-loaded by the trace instead.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
If a trace was loaded, essentially the config values from the trace should be respected as the "defaults". See addt'l context for caveat(s).
Screenshots
N/A
Desktop (please complete the following information):
N/A
Mobile (please complete the following information):
N/A
Additional context
There is a gotcha here, which is that if the developer truly does want a "blank" Playground with reasonable defaults, how should they get to it? We could do two buttons ("Reset changes" and "Use defaults"). Or...something else?
FWIW, clicking the model again on the LHS will reset to the defaults (i.e. clean playground).
cc @pavelgj @mjchristy @shrutip90
The text was updated successfully, but these errors were encountered: