Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev UI] Reset button should respect initial model params set from trace #729

Closed
MichaelDoyle opened this issue Aug 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working devui tooling

Comments

@MichaelDoyle
Copy link
Member

MichaelDoyle commented Aug 1, 2024

Describe the bug
The "reset" button for the model config sets all values to the "default" values. However, when if the runner was loaded from a trace, we should probably reset to the values pre-loaded by the trace instead.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the model runner, and tweak some configurations. Run a prompt.
  2. Click view trace
  3. Click "open in model runner..." (yes, you've made a loop 😝 )
  4. Click reset (values from trace will be "lost")

Expected behavior
If a trace was loaded, essentially the config values from the trace should be respected as the "defaults". See addt'l context for caveat(s).

Screenshots
N/A

Desktop (please complete the following information):
N/A

Mobile (please complete the following information):
N/A

Additional context
There is a gotcha here, which is that if the developer truly does want a "blank" Playground with reasonable defaults, how should they get to it? We could do two buttons ("Reset changes" and "Use defaults"). Or...something else?

FWIW, clicking the model again on the LHS will reset to the defaults (i.e. clean playground).

cc @pavelgj @mjchristy @shrutip90

@MichaelDoyle MichaelDoyle added bug Something isn't working tooling labels Aug 1, 2024
@MichaelDoyle MichaelDoyle changed the title [Tooling] Reset button should respect initial model params set from trace [Dev UI] Reset button should respect initial model params set from trace Nov 7, 2024
@tonybaroneee tonybaroneee self-assigned this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devui tooling
Projects
Status: Done
Development

No branches or pull requests

3 participants