[firebase_admob] Added note about GoogleService-list.plist #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note about GoogleService-list.plist which is not required in order to use Admob's latest version. Without this file, the app will crash on startup.
bparrishMines
suggested changes
Mar 5, 2020
packages/firebase_admob/README.md
Outdated
| @@ -73,6 +73,8 @@ Starting in version 7.42.0, you are required to add your AdMob app ID in your ** | |||
|
|
|||
| Failure to add this tag will result in the app crashing at app launch with a message including *"GADVerifyApplicationID."* | |||
|
|
|||
| You are also required to create an "App" in firebase and generate a GoogleService-info.plist file. This file needs to be embedded in the projects "Runner/Runner" folder using Xcode. If this step isn't done, the app will crash on startup. | |||
There was a problem hiding this comment.
Since this is required for Android and iOS, I think it would be better to create a section for "Configuring a Firebase Project". It would also be beneficial to point to documentation from Firebase about how to create an "App". Some documentation I found for Android:
https://firebase.google.com/docs/android/setup#create-firebase-project -> Steps 1-3.1
for iOS:
https://firebase.google.com/docs/ios/setup#create-firebase-project -> Steps 1-3
There was a problem hiding this comment.
Good point. I will add a section for each.
bparrishMines
approved these changes
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note about GoogleService-list.plist which is not required in order to use Admob's latest version. Without this file, the app will crash on startup.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?