Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm workspaces support broken since 11.19.0 #5385

Closed
mpsq opened this issue Jan 3, 2023 · 3 comments
Closed

npm workspaces support broken since 11.19.0 #5385

mpsq opened this issue Jan 3, 2023 · 3 comments
Assignees
@taeold
Labels
api: functions type: bug

Comments

@mpsq
Copy link

mpsq commented Jan 3, 2023 •
edited
Loading

Firebase CLI is broken since #5215 when using npm workspaces. (11.18.0 works fine)

Environment info

  • firebase-tools 11.19.0
  • npm 8.18
  • node 16
  • npm workspaces
  • Archlinux

Test case

Steps to reproduce

Any firebase cli command with npm workspaces set up

Expected behavior

Command should succeed

Actual behavior

Errors (not sure the 1st is relevant):

Could not find functions.yaml. Must use http discovery
Error: spawn ./node_modules/.bin/firebase-functions ENOENT
@mpsq mpsq added the bug label Jan 3, 2023
@mpsq
Copy link
Author

mpsq commented Jan 3, 2023 •
edited
Loading

The issue seems to be on https://github.com/firebase/firebase-tools/blob/master/src/deploy/functions/runtimes/node/index.ts#L111, this.sourceDir references the module and not the root (where node_modules is)

@joehan
Copy link
Contributor

joehan commented Jan 3, 2023

@taeold Seems like this may be related to #4952?

@taeold
Copy link
Contributor

taeold commented Jan 3, 2023

Thanks @joehan. Closing in favor of #4952

@taeold taeold closed this as completed Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taeold taeold

Labels
api: functions type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joehan @mpsq @taeold @christhompsongoogle @aalej