fix filter check to allow firestore targets #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
Jul 8, 2022
dalenguyen
reviewed
Jul 10, 2022
| @@ -38,13 +38,13 @@ export async function checkValidTargetFilters(options: Options): Promise<void> { | |||
| return reject(new FirebaseError("Cannot specify both --only and --except")); | |||
| } | |||
| const nonFilteredTypes = VALID_DEPLOY_TARGETS.filter( | |||
| (t) => !["hosting", "functions"].includes(t) | |||
| (t) => !["hosting", "functions", "firestore"].includes(t) | |||
There was a problem hiding this comment.
Hi @bkendall, just want to chime in. Does it also support storage?
Our pipeline also deploy storage rules with --only
firebase deploy --only storage:rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4698
--only firestore:ruleswas not working (or:indexes) because the check only allowedhostingorfunctionsto specify targets like that. This check was fixed when it was rewritten to actually return errors, but it didn't includefirestorein the allowed list for targets.Scenarios Tested
firebase deploy --only firestore:rulesfirebase deploy --except firestore:rulesfirebase deploy --only hostingfirebase deploy --only hosting:main