Allow Firestore emulator UI websocket port to be configurable #4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.98% // Head: 56.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4925 +/- ##
==========================================
- Coverage 56.98% 56.94% -0.04%
==========================================
Files 291 291
Lines 19471 19486 +15
Branches 3900 3904 +4
==========================================
+ Hits 11095 11097 +2
- Misses 7437 7450 +13
Partials 939 939
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
FYI @markarndt This will affect the config in https://firebase.google.com/docs/emulator-suite/install_and_configure#port_configuration |
yuchenshi
reviewed
Sep 1, 2022
Co-authored-by: Yuchen Shi <[email protected]>
yuchenshi
approved these changes
Sep 23, 2022
christhompsongoogle
approved these changes
Sep 23, 2022
christhompsongoogle
pushed a commit
that referenced
this pull request
Sep 30, 2022
* feat: allow firestore ui websocket to be configurable through firebase.json * feat: add logging for firestore ui websocket port reservation when starting cli * feat: add logging for websocket port in emulator start cli, fix lint * Update src/emulator/controller.ts Co-authored-by: Yuchen Shi <[email protected]> * fix: camel case * fix: camel casing * fix: typo * fix: function naming * fix: linting * feat: update cloud firestore versions * fix: update jar size * Update CHANGELOG.md * Update downloadableEmulators.ts * Update downloadableEmulators.ts Co-authored-by: Yuchen Shi <[email protected]>
christhompsongoogle
pushed a commit
that referenced
this pull request
Sep 30, 2022
* feat: allow firestore ui websocket to be configurable through firebase.json * feat: add logging for firestore ui websocket port reservation when starting cli * feat: add logging for websocket port in emulator start cli, fix lint * Update src/emulator/controller.ts Co-authored-by: Yuchen Shi <[email protected]> * fix: camel case * fix: camel casing * fix: typo * fix: function naming * fix: linting * feat: update cloud firestore versions * fix: update jar size * Update CHANGELOG.md * Update downloadableEmulators.ts * Update downloadableEmulators.ts Co-authored-by: Yuchen Shi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #3837
Adding optional field
websocket_portto Firestore emulator in Firebase.json, which allows the Firestore emulator UI websocket port to be configurable.Note: Updates Firestore version from 1.14.4 to 1.15.0
Scenarios Tested
Sample Commands