Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix emulator configuration warnings #2292

Merged
merged 3 commits into from
May 27, 2020
Merged

Fix emulator configuration warnings #2292

merged 3 commits into from
May 27, 2020

Conversation

samtstern
Copy link
Contributor

Description

Fixes #2290

Scenarios Tested

Produces a warning

{
  "emulators": {
    "functions": {
      "port": 5001
    },
    "hosting": {
     "port": 5000 
    },
    "ui": {
      "enabled": true
    }
  }
}

Does not produce a warning:

{
  "emulators": {
    "functions": {
      "port": 5001
    },
    "ui": {
      "enabled": true
    }
  }
}

Sample Commands

N/A

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label May 26, 2020
@samtstern samtstern requested a review from abeisgoat May 26, 2020 15:11
@samtstern samtstern merged commit e04591d into master May 27, 2020
@bkendall bkendall deleted the ss-fix-2290 branch August 4, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hosting emulator config incorrectly detected
3 participants