Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pashto and dari languages #88

Open
MirwaisAkrami opened this issue Apr 22, 2020 · 4 comments
Open

Add support for pashto and dari languages #88

MirwaisAkrami opened this issue Apr 22, 2020 · 4 comments

Comments

@MirwaisAkrami
Copy link

As the Jalali calendar is used in Afghanistan as well, this library fits our needs perfectly here, except for the the names of the months, which needs to be translated to Dari and Pashto

Just as the support of Farsi is added, if you could add support for Dari (fa-AF) and Pashto (ps) as well.

I have checked the library code and I think the only modification we will need is to make the locale to be chosen from three languages rather then just 'fa' and add moment.updateLocale('fa-AF', {}) and moment.updateLocale('ps', {}) for the two languages.

I can provide the locale objects for both the languages if you agree to add them and will provide any further technical assistance if required.

@fingerpich
Copy link
Owner

Yes I think so, there shouldn't be any problem
Try the idea and let us know in this issue
then we will merge it or add a link to the fork that you have created.

@MirwaisAkrami
Copy link
Author

Sure, I will implement the feature and will let you know.

@byteab
Copy link

byteab commented Dec 5, 2020

@fingerpich how can I make a PR is there any .ts file. as it seems files inside library are build files. I mean should I directly change these files are you provide the actual .ts or any high level files

@fingerpich
Copy link
Owner

The main code is in jalali-moment.js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants