Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jalali diff not working on different server & client timezone #104

Open
aminmokhtari94 opened this issue Sep 5, 2020 · 2 comments
Open

Comments

@aminmokhtari94
Copy link

aminmokhtari94 commented Sep 5, 2020

Bug demo:
https://stackblitz.com/edit/jalali-moment-demo-react-cvdbk4?file=index.js

Describe:

  • Day diff function wont work if on geo timezone days was same but on jalali not!
  • Passing 'jDay', 'jMonth', etc. to diff second arg not working

Expected:

@aminmokhtari94 aminmokhtari94 changed the title jalali diff not working jalali diff not working on different server & client timezone Sep 5, 2020
@fingerpich
Copy link
Owner

Actually i didn't get what you mean
I think diff('jday') is equal to diff('day'), isn't it?
and in demo I see a&b days diff = 16 - 16 = 0 is it wrong or what?
can you please describe more?

@fingerpich
Copy link
Owner

Can you please take a look at the following PR
ce87bc4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants