Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule to detect CDS.Default-Component used within CDS.OnPush #6

Open
ajafff opened this issue Jan 13, 2020 · 0 comments
Open

Add rule to detect CDS.Default-Component used within CDS.OnPush #6

ajafff opened this issue Jan 13, 2020 · 0 comments
Labels
help wanted Extra attention is needed rule suggestion

Comments

@ajafff
Copy link
Member

ajafff commented Jan 13, 2020

If any parent component uses ChangeDetectionStrategy.OnPush, it will affect change detection in child components. If a child component uses ChangeDetectionStrategy.Default it might not function as expected.
This might even work with components from libraries as the metadata contains information about the change detection.
@ajafff ajafff added help wanted Extra attention is needed rule suggestion labels Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed rule suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajafff