Bug: Formatting Issue with Dimensions and Synchronization Labels

[Lukiluc29]

Description

I have noticed a formatting issue with the labels "dimensions" and "synchronization" when hovering over an image. The colon is directly attached to the word "dimensions" resulting in "dimensions:" instead of "dimensions :". The same problem occurs with the "synchronization" line. To fix this, the colons should be removed from the following lines of code in the file "src/Files.App/Data/Items/ListedItem.cs" on line 49-50

if (!string.IsNullOrWhiteSpace(DimensionsDisplay))
    tooltipBuilder.Append($"{Environment.NewLine}{"PropertyDimensions".GetLocalizedResource()}: {DimensionsDisplay}");
if (SyncStatusUI.LoadSyncStatus)
    tooltipBuilder.Append($"{Environment.NewLine}{"syncStatusColumn/Header".GetLocalizedResource()}: {syncStatusUI.SyncStatusString}");

and ensure that "dimensions" and "dimensions:", as well as "status" and "status:", are properly localized.

Steps To Reproduce

1. Hover over an image file
2. Hover over a file stored in the cloud

Requirements

Correct the code so that the labels are formatted properly, with a space between the word and the colon.

Files Version

3.4.14.0

Windows Version

10.0.22631.3737

Log File

[yaira2]

There are two approaches to take here, the first is to have separate strings with and without the colons. The other approach is to have a dedicated string for colon.

[0x5bfa]

As we have done, let's have DimentionsWithColon

[yaira2]

Sounds good

[0x5bfa]

@Lukiluc29 Do you like to work on this?

[Lukiluc29]

@Lukiluc29 Do you like to work on this?

I'm sorry, but I am unable to address this issue as I do not have a workstation to work on it.

[Lukiluc29]

If someone else is willing to take on this task, it would be greatly appreciated.

[0x5bfa]

Sure! I'll address this issue and make sure this will be included in the next stable build!

[yaira2]

@0x5bfa if you don't mind, perhaps we can let someone else take this as it can be a good starting issue for a beginner.

[0x5bfa]

Good idea! Let's leave.