Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing errormessage if directory does not exist #34

Closed
rubo77 opened this issue Jul 27, 2018 · 4 comments
Closed

missing errormessage if directory does not exist #34

rubo77 opened this issue Jul 27, 2018 · 4 comments

Comments

@rubo77
Copy link
Contributor

rubo77 commented Jul 27, 2018

If you specify a directory with -d that does not exist, the service runs luckily anyway, although it doesn't find any provider!

@TobleMiner
Copy link
Member

Can't reproduce

sudo /opt/mesh-announce/respondd.py -d /non-existent-directory -i br-ffki -i ffki-mvpn -b bat-ffki -m 10.116.160.1
Traceback (most recent call last):
  File "/opt/mesh-announce/respondd.py", line 70, in <module>
    get_handler(get_providers(args.directory), {'batadv_dev': args.batadv_iface, 'mesh_ipv4': args.mesh_ipv4})
  File "/opt/mesh-announce/providers/__init__.py", line 150, in get_providers
    raise FileNotFoundError("The path '{}' is not a valid directory".format(directory))
FileNotFoundError: The path '/non-existent-directory' is not a valid directory

@rubo77
Copy link
Contributor Author

rubo77 commented Jul 27, 2018

I used

-d /opt/mesh-announce/provider

Without s

Maybe there was an error in the log, I only checked if the sevicre was running and it was active although the path was wrong.

It should refuse to start

@TobleMiner
Copy link
Member

You can't "refuse" to start. The service simply crashes as soon as it hits that error

@rubo77
Copy link
Contributor Author

rubo77 commented Jul 28, 2018

strange, I think it was running before with thy typo in the path, but I cannot reproduce it now either

@rubo77 rubo77 closed this as completed Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants