Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add antialiasing option to Resample and RandomAffine #48

Open
fepegar opened this issue Jan 15, 2020 · 2 comments
Open

Add antialiasing option to Resample and RandomAffine #48

fepegar opened this issue Jan 15, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fepegar
Copy link
Owner

fepegar commented Jan 15, 2020

As in NifTK/NiftyNet@a91644b#diff-5b79901b7b2f56394aca30c562e9e186

@fepegar fepegar added the enhancement New feature or request label Jan 17, 2020
@sairampillai
Copy link

Hey @fepegar. I would like to contribute. Would this be a good issue to start with? Any other details regarding this issue?

@fepegar
Copy link
Owner Author

fepegar commented Jan 22, 2020

Hi @sairampillai. Thanks for your interest!
Yes, this might be a good one. I had in mind something like what I did for NiftyNet:

https://github.com/NifTK/NiftyNet/blob/7421b013e5d7852f2eab1861de0bc768995ec82b/niftynet/layer/rand_spatial_scaling.py#L67-L73

You can start by

  1. Fork this repo
  2. Create a branch 48-add-antialiasing on the fork
  3. Commit your changes to that branch
  4. Submit a pull request to this repo, even if it's not ready

I'll review the commits and merge your changes.

Thank you!

@fepegar fepegar added the good first issue Good for newcomers label Feb 8, 2020
@fepegar fepegar closed this as completed May 5, 2020
@fepegar fepegar reopened this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants