Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silenced exception in Queue when using faulty transform #1101

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

Zhack47
Copy link
Contributor

@Zhack47 Zhack47 commented Aug 3, 2023

Fixes #1098.

Description

Fixed a bug where a faulty (e.g.: custom) transform used in a Queue would throw an error that would be caught by a try / except statement but ignored, causing an UnboundLocalError. This error did not give any information on the original exception, making it harder to understand that the origin of the problem is a faulty transform.

This PR makes the Queue raises the original exception

Checklist

  • [ x] I have read the CONTRIBUTING docs and have a developer setup (especially important are pre-commitand pytest)
  • [x ] Non-breaking change (would not break existing functionality)
  • Breaking change (would cause existing functionality to change)
  • Tests added or modified to cover the changes
  • [ x] Integration tests passed locally by running pytest
  • In-line docstrings updated
  • Documentation updated, tested running make html inside the docs/ folder
  • [ x] This pull request is ready to be reviewed

@fepegar fepegar merged commit be2b369 into fepegar:main Aug 3, 2023
13 checks passed
@fepegar
Copy link
Owner

fepegar commented Aug 3, 2023

Thanks again for your contribution, @Zhack47!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silenced exception makes it harder to debug custom Transforms
2 participants