Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script returns with exit code 0 after error #19

Closed
felixvanoost opened this issue Feb 13, 2024 · 0 comments · Fixed by #20
Closed

Script returns with exit code 0 after error #19

felixvanoost opened this issue Feb 13, 2024 · 0 comments · Fixed by #20
Assignees
Labels
bug Something isn't working

Comments

@felixvanoost
Copy link
Owner

jekyll-kroki returns with an exit code of 0 (success) after an error occurs, leading any upstream scripts that originally called the Jekyll command to ignore the error.

For instance, with the Kroki URL set to https://expired.badssl.com/:

[jekyll-kroki] "SSL_connect returned=1 errno=0 state=error: certificate verify failed (certificate has expired)" in 'render_diagram' on line 76 of /workspaces/jekyll-kroki/lib/jekyll/kroki.rb
$ echo $?
0
@felixvanoost felixvanoost added the bug Something isn't working label Feb 13, 2024
@felixvanoost felixvanoost self-assigned this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant