Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageHelper.nextPage() fails to handle the final page #679

Open
wallslide opened this issue Mar 23, 2023 · 2 comments
Open

PageHelper.nextPage() fails to handle the final page #679

wallslide opened this issue Mar 23, 2023 · 2 comments

Comments

@wallslide
Copy link

When using PageHelper.nextPage() (code here), the final page isn't handled correctly. Internally, the helper fails to mutate its state if the after cursor is undefined. This means nextPage() endlessly repeats querying and returning the final page rather than indicating that there are no more pages left.
@github-actions
Copy link

Internal ticket number is FE-3288

@wallslide
Copy link
Author

Possibly relevant detail. This behavior was happening when all the data fit into a single page. I wasn't able to test if data that spanned multiple pages works because of #680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wallslide