Adds support for @bytes type
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickpintor
reviewed
Feb 1, 2017
| _Value = FromUrlSafeBase64(base64); | ||
| } | ||
|
|
||
| public BytesV(params byte[] value) |
There was a problem hiding this comment.
Does this constructor allow for an array of bytes to come in instead of a varargs?
FaunaDB.Client/Types/BytesV.cs
Outdated
|
|
||
| static byte[] FromUrlSafeBase64(string urlSafe) | ||
| { | ||
| var base64 = urlSafe.Replace('_', '/').Replace('-', '+'); |
There was a problem hiding this comment.
Is this a standard transformation? Is there a changes where actual underscores or dashes shouldn't be replaced?
Perhaps we should put a comment explaining this.
There was a problem hiding this comment.
This is not standard but it's a common transformation made by most of libraries.
https://docs.python.org/2/library/base64.html#base64.urlsafe_b64encode
https://en.wikipedia.org/wiki/Base64#URL_applications
https://stackoverflow.com/a/26354677
There was a problem hiding this comment.
Would you mind documenting that in the code for posterity?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/faunadb/sales-engineering/issues/508