Remove nullish coalescing operator from build to support webpack 4

[henryfauna]

Ticket(s): FE-###

Problem

Webpack 4 (used by CRA) does not support the nullish coalescing operator.

Solution

Use a babel plugin to transpile the operator at build time.

Result

A build which can be used by CRA apps.

Out of scope

N/A

Testing

Ran build and verified no instances of ??

[cleve-fauna]

What is CRA?

[henryfauna]

What is CRA?

Create React App - which bundles a bunch of stuff under react-scripts including webpack

[cleve-fauna]

Do we want to use CRA? I believe we kind of have dependency hell due to it.

[henryfauna]

Do we want to use CRA? I believe we kind of have dependency hell due to it.

Well we are using it for the new dashboard - we can eject and do it by hand but went with that for now for expediency. Plus it's generally very widely used so good to support it. I figure others will run into this fairly quickly once it's public.

[cleve-fauna]

Do we want to use CRA? I believe we kind of have dependency hell due to it.

Well we are using it for the new dashboard - we can eject and do it by hand but went with that for now for expediency. Plus it's generally very widely used so good to support it. I figure others will run into this fairly quickly once it's public.

• I agree we should make this build output compatible to it
• but I would like to see a deep dive on if we should use it for a production website (so orthogonal to this driver).
• from the (brief) dive I did into our current website performance the default CRA settings were putting the app into one huge file and the dependency hell problems seem to stem from CRA hiding implementation
• that being said - its probably good for prototyping; but i would like to see a well thought out case before we settle on it. Can you add a card to the post-beta for this? Please link the card here.

[cleve-fauna]

@henryfauna instead of hacking babel let's do it the esbuild way:

https://esbuild.github.io/content-types/#javascript

[mwilde345]

I agree CRA is not what we want for a final production build, and I remember some discussions about using rollup or even a new flashy build system like vite.

[henryfauna]

I agree CRA is not what we want for a final production build, and I remember some discussions about using rollup or even a new flashy build system like vite.

Ooh yeah vite would be cool