Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Explorer page, binary tab, fails to show images. #437

Closed
madhacker3kxl opened this issue Mar 1, 2024 · 3 comments · Fixed by #446
Closed

[Bug]: Explorer page, binary tab, fails to show images. #437

madhacker3kxl opened this issue Mar 1, 2024 · 3 comments · Fixed by #446
Assignees
@AnalogJ
Labels
bug Something isn't working

Comments

@madhacker3kxl
Copy link

Contact Details

No response

What happened?

When viewing the explorer page and in binary tab, click on an image/jpeg shows an error.

image
image

Flavor

Docker

Version

main#e4a73ff

Relevant log output

level=error msg="An error occurred while retrieving resource no resource found with source id 6dccfd76-53a1-4ca3-b130-b387f954011e and source resource id aHR0cHM6Ly93d3cubWVyY3kubmV0L3NpdGVzL2RlZmF1bHQvZmlsZXMvZG9jdG9yX2ltYWdlcy9kZXNrdG9wLzE2NTk4ODYwNTktbS5qcGc" type=web
@madhacker3kxl madhacker3kxl added the bug Something isn't working label Mar 1, 2024
@AnalogJ
Copy link
Member

AnalogJ commented Mar 4, 2024

figured out the issue. We arn't url-encoding the source-resource-id, which is base64 encoded in some cases

aHR0cHM6Ly93d3cubWVyY3kubmV0L3NpdGVzL2RlZmF1bHQvZmlsZXMvZG9jdG9yX2ltYWdlcy9kZXNrdG9wLzE2NTk4ODYwNTktbS5qcGc=

should be:

aHR0cHM6Ly93d3cubWVyY3kubmV0L3NpdGVzL2RlZmF1bHQvZmlsZXMvZG9jdG9yX2ltYWdlcy9kZXNrdG9wLzE2NTk4ODYwNTktbS5qcGc%3D

the = is a reserved character in URLs.

@madhacker3kxl
Copy link
Author

Nice catch! Noticed that the log I attached above does not have the "="

@AnalogJ
Copy link
Member

AnalogJ commented Mar 5, 2024

yep, I'll work on getting that fixed. There's about a dozen different places where we do that, so it might take a bit :(

@jean-the-coder jean-the-coder mentioned this issue Mar 7, 2024
Merged
@AnalogJ AnalogJ mentioned this issue Mar 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnalogJ AnalogJ

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix URL encoding issue for links jean-the-coder/fasten-onprem
2 participants
@AnalogJ @madhacker3kxl