Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Labs Glossary Horizontal Overflow #408

Closed
mark-velez opened this issue Feb 6, 2024 · 1 comment · Fixed by #445
Closed

[Bug]: Labs Glossary Horizontal Overflow #408

mark-velez opened this issue Feb 6, 2024 · 1 comment · Fixed by #445
Assignees
@jean-the-coder
Labels
bug Something isn't working

Comments

@mark-velez
Copy link

mark-velez commented Feb 6, 2024 •
edited
Loading

Contact Details

What happened?

On the labs page, the glossary overflows horizontally over the dashboard card block for some content.

OS: Windows 11
Browser: Google Chrome 121.0.6167.140

image

image

Expected behavior

Glossary is contained within the dashboard card block.

Possible fix

Removing display: inline-block rule from glossary-lookup.component.scss#L4 using Developer Tools seems to fix-- I'm not sure if it breaks anything though.

Flavor

Docker

Version

main#74a1819

Relevant log output

No response
@mark-velez mark-velez added the bug Something isn't working label Feb 6, 2024
@AnalogJ
Copy link
Member

AnalogJ commented Feb 7, 2024

hey @mark-velez
My understanding is that this is due to the fact that the HTML provided by some National Library of Medicine snippets is invalid (missing closing tags).

While I haven't played with the inline-block class, I'm surprised that this would have an effect on this issue.

@AnalogJ AnalogJ assigned jean-the-coder and unassigned AnalogJ Mar 4, 2024
@jean-the-coder jean-the-coder mentioned this issue Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jean-the-coder jean-the-coder

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix horizontal overflow for glossary lookup jean-the-coder/fasten-onprem
3 participants
@AnalogJ @mark-velez @jean-the-coder