-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add creditCardIssuer #888
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for this.
expect(Object.keys(.....credit_card)).toContain(actual)
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 1959 1959
Lines 210905 210917 +12
Branches 906 907 +1
=======================================
+ Hits 209675 209687 +12
Misses 1172 1172
Partials 58 58
|
Should we focus and merge #503 first? |
I've got this ready locally but I've noticed 'provider' is also used in
|
test/finance.spec.ts line 397 |
303369e
Adds method for randomly selecting a credit card provider from the keys of
faker.definitions.finance.credit_card
For pull request #882