Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize provider in finance.creditCardNumber #662

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Mar 23, 2022
@Shinigami92 Shinigami92 added this to the v6.1 - First bugfixes milestone Mar 23, 2022
@Shinigami92 Shinigami92 self-assigned this Mar 23, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner March 23, 2022 19:07
@Shinigami92 Shinigami92 linked an issue Mar 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #662 (9861398) into main (91a1aab) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files        1923     1923              
  Lines      176855   176856       +1     
  Branches      915      913       -2     
==========================================
- Hits       175687   175686       -1     
- Misses       1112     1114       +2     
  Partials       56       56              
Impacted Files Coverage Δ
src/finance.ts 100.00% <100.00%> (ø)
src/vendor/unique.ts 93.54% <0.00%> (-1.62%) ⬇️

@ST-DDT ST-DDT requested a review from a team March 23, 2022 23:39
@Shinigami92 Shinigami92 merged commit 9ce1551 into main Mar 24, 2022
@Shinigami92 Shinigami92 deleted the 527-finance-credit-card-number-should-lowercase-the-provider-name branch March 24, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finance credit card number should lowercase the provider name
3 participants