-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: corrected the Costa Rican IBAN format #646
Conversation
Co-authored-by: Halvor <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #646 +/- ##
=======================================
Coverage 99.33% 99.33%
=======================================
Files 1923 1923
Lines 176853 176857 +4
Branches 906 908 +2
=======================================
+ Hits 175681 175687 +6
+ Misses 1116 1114 -2
Partials 56 56
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked and seems to be working according to: https://www.iban.de/iban-pruefen.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have a test case for that? Nothing failed...
But I think we should add a test case for that because we also have tests for other ibans
See: https://github.com/faker-js/faker/blob/main/test/finance_iban.spec.ts
I added the test for Costa Rica to the test file and made issue #660 for the other tests of missing IBAN country codes. In the latest commit I also splitted the reserved character from the banking digits of the Costa Rican IBAN formatting, to really cohere to the definitions I have found online. |
Fixes #643 by correcting the Costa Rican IBAN formatting