-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve specification of lorem module and definitions #2884
Comments
Suggestion by @matthewmayer If it is identical to en could we not just have words.ts be like this to avoid duplication: import words from '../../en/lorem/words';
export default words; |
I'll create a PR for the documentation part. Unless you are already working on it. |
This raises my impression that lorem should be strictly Latin only and we should probably add |
Honestly, as long as we have a clear definition I'm fine with it. It's not like we can't change it in the future, if required. |
If we do decide to to keep lorem non-Latin languages we should definitely allow for languages that don't have a space as a word seperator (e.g. Chinese, Thai). For example here you'd probably want to use a definition like faker.definitions.lorem.word_seperator instead of a hardcoded ' '. |
Team Proposal
|
FFR: We now use it for domain words as well, so it using latin letters would help with that: |
Languages that use latin characters should use the latin lorem text (e.g. copy it from en).
We will create a separate PR that will document this behavior of the lorem feature in the definitions and module.
After the change of definitions we should create another PR that actually changes the locale data to comply with the new spec and additional care should be taken regarding tree shakeability if the locale data are imported from other locales.
Especially the later part should be done by the team to ensure there are no side effects.
Originally posted by @ST-DDT in #2824 (comment)
The text was updated successfully, but these errors were encountered: