-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adafactor sum instead of mean? #5290
Labels
Comments
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
馃悰 Bug
Hi! I was looking at the pseudocode for the adafactor paper, and I noticed that it is slightly different from the fairseq implementation in that, in fairseq's adafactor we use mean to reduce
and
when they are all supposed to be sum instead? Here's the pseudo-code from the paper
I made a pr to fix this issue if needed!
The text was updated successfully, but these errors were encountered: