Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unsigned long to unsigned long long in gloo/cuda_allreduce_ring_chunked.cc and gloo/allreduce_ring_chunked.h #265

Open
gunandrose4u opened this issue Sep 10, 2020 · 0 comments

Comments

@gunandrose4u
Copy link
Contributor

Code review comment from Orvid in PR #264

Just make this explicitly an unsigned long long. long is 64-bit on linux, but 32-bit on windows, so it's far better to make this explicit. (I would recommend searching through gloo for any references to bare long and fixing them, otherwise you're likely to run into issues later)

Issues:
Simply change unsigned long to unsigned long long will leads test code compile error. Need investigate and fix conflicts in test code introduced by this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant