{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":80786957,"defaultBranch":"main","name":"gloo","ownerLogin":"facebookincubator","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-02-03T01:37:01.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/19538647?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1697569456.0","currentOid":""},"activityList":{"items":[{"before":"c82c8b9387151372fce889215316225cdd44565b","after":"81925d1c674c34f0dc34dd9a0f2151c1b6f701eb","ref":"refs/heads/main","pushedAt":"2024-06-26T14:28:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/allgatherv.cc\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D59008860\n\nfbshipit-source-id: 5966c74486b9f48092eba840a8801db60a4ac326","shortMessageHtmlLink":"Fix shadowed variable in gloo/allgatherv.cc"}},{"before":"0dd455816e4288c6f6f056e5d951d21487f18fb2","after":"c82c8b9387151372fce889215316225cdd44565b","ref":"refs/heads/main","pushedAt":"2024-05-24T22:08:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in gloo/mpi/example/main_unmanaged.cc +1\n\nSummary:\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nRemoving this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D57793834\n\nfbshipit-source-id: 464397c542c61d6838285d4c90cbbe81767953b3","shortMessageHtmlLink":"Remove unused-but-set variables in gloo/mpi/example/main_unmanaged.cc +1"}},{"before":"85f72f1c06291f4a137103fa17d4244eb948bdbe","after":"0dd455816e4288c6f6f056e5d951d21487f18fb2","ref":"refs/heads/main","pushedAt":"2024-05-06T05:08:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Change `result_of` to `invoke_result` in gloo/transport/uv/libuv.h\n\nSummary: C++20 has [eliminated](https://en.cppreference.com/w/cpp/types/result_of) `result_of` in favour of `invoke_result`. It's mysterious that this code even still works, but, nevertheless, I'm fixing it.\n\nDifferential Revision: D56987407\n\nfbshipit-source-id: 3ebe7bb70af42590fa88e49641c5fcd559aa2ad9","shortMessageHtmlLink":"Change <code>result_of</code> to <code>invoke_result</code> in gloo/transport/uv/libuv.h"}},{"before":"c83cdab66aea9cb6c5cdf8e2e13383e683d2bacd","after":"85f72f1c06291f4a137103fa17d4244eb948bdbe","ref":"refs/heads/main","pushedAt":"2024-04-27T03:02:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_bcube.h + 1\n\nSummary:\n`nullptr` is typesafe. `0` and `NULL` are not. In the future, only `nullptr` will be allowed.\n\nThis diff helps us embrace the future _now_ in service of enabling `-Wzero-as-null-pointer-constant`.\n\nReviewed By: palmje\n\nDifferential Revision: D56650319\n\nfbshipit-source-id: 3d9dbb5972173636c9512677f7d78674f61f1df4","shortMessageHtmlLink":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_bcube.h + 1"}},{"before":"71868d0b643c53296673be2a2ef32c912cc9d3e1","after":"c83cdab66aea9cb6c5cdf8e2e13383e683d2bacd","ref":"refs/heads/main","pushedAt":"2024-04-27T01:59:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_ring.h + 1\n\nSummary:\n`nullptr` is typesafe. `0` and `NULL` are not. In the future, only `nullptr` will be allowed.\n\nThis diff helps us embrace the future _now_ in service of enabling `-Wzero-as-null-pointer-constant`.\n\nReviewed By: palmje\n\nDifferential Revision: D56650277\n\nfbshipit-source-id: a9be03583ac815de0b2b2d240adad4d3aa42d47e","shortMessageHtmlLink":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_ring.h + 1"}},{"before":"6c70a556237b6fa08b1a10a8511445dd5c58cb59","after":"71868d0b643c53296673be2a2ef32c912cc9d3e1","ref":"refs/heads/main","pushedAt":"2024-04-27T01:53:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_halving_doubling.h + 1\n\nSummary:\n`nullptr` is typesafe. `0` and `NULL` are not. In the future, only `nullptr` will be allowed.\n\nThis diff helps us embrace the future _now_ in service of enabling `-Wzero-as-null-pointer-constant`.\n\nReviewed By: palmje\n\nDifferential Revision: D56650289\n\nfbshipit-source-id: 0a320e181876b91bfea27a8400f0a1eb4b827ed9","shortMessageHtmlLink":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_halving_doubling.…"}},{"before":"2565674cd77c79df8ad9e36109a2959b1fd4c213","after":"6c70a556237b6fa08b1a10a8511445dd5c58cb59","ref":"refs/heads/main","pushedAt":"2024-04-11T18:57:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in glean/rts/tests/SubstitutionTest.cpp\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D56022388\n\nfbshipit-source-id: 1ce16bb29d0a9b4f5735122089f8e9c51846a27f","shortMessageHtmlLink":"Remove unused variables in glean/rts/tests/SubstitutionTest.cpp"}},{"before":"3e68ba19df45ff68bf20216a0b8588b8d9035676","after":"2565674cd77c79df8ad9e36109a2959b1fd4c213","ref":"refs/heads/main","pushedAt":"2024-03-03T01:41:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"apply Black 2024 style in fbcode (8/16)\n\nSummary:\nFormats the covered files with pyfmt.\n\npaintitblack\n\nReviewed By: aleivag\n\nDifferential Revision: D54447737\n\nfbshipit-source-id: 6c05d7941c6b4f1787b8da6cf810693f48a96c4e","shortMessageHtmlLink":"apply Black 2024 style in fbcode (8/16)"}},{"before":"1161c1cfc842dd7427c1ab728784238575d0dec2","after":"3e68ba19df45ff68bf20216a0b8588b8d9035676","ref":"refs/heads/main","pushedAt":"2024-02-26T05:57:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_ring_chunked.h + 3\n\nSummary:\n`nullptr` is typesafe. `0` and `NULL` are not. In the future, only `nullptr` will be allowed.\n\nThis diff helps us embrace the future _now_ in service of enabling `-Wzero-as-null-pointer-constant`.\n\nReviewed By: meyering\n\nDifferential Revision: D54163047\n\nfbshipit-source-id: 6f44e83af686111d6f47d51b81a3108ceb01b31e","shortMessageHtmlLink":"Fix deprecated use of 0/NULL in gloo/cuda_allreduce_ring_chunked.h + 3"}},{"before":"d1846caab5e4bb1f19da1428fee8e8adb3740d06","after":"1161c1cfc842dd7427c1ab728784238575d0dec2","ref":"refs/heads/main","pushedAt":"2024-02-26T05:47:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix deprecated behaviour in gloo/rendezvous/store.h\n\nSummary:\nFuture C++ standards and compiler upgrades will eliminate deprecated behaviour. `-Wdeprecated` identifies this behaviour and has found some in this code!\n\nSome examples.\n\n**Dynamic exceptions**\n```\nerror: dynamic exception specifications are deprecated [-Werror,-Wdeprecated-dynamic-exception-spec]\n```\n`throw(...)` has been deprecated since C++11 and removed in C++17. In most cases we can just use `noexcept` in the rest, we can remove this.\n\n**Implicit copy constructors**\n```\nerror: definition of implicit copy constructor for 'XXX' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated-copy-with-dtor]\n```\nIf you define a destructor, you need to explicitly define a copy constructor.\n\n**Out-ofline constexpr static**\n```\nerror: out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated]\n```\nThis can be simplified:\n```\nclass MyClass {\n    static constexpr my_const = 3;\n};\n\nstatic constexpr MyClass::my_const; // <- No longer needed!\n```\n\nReviewed By: meyering\n\nDifferential Revision: D54158184\n\nfbshipit-source-id: f3b98790d6592ac21e6d002b2d0d914bc331735d","shortMessageHtmlLink":"Fix deprecated behaviour in gloo/rendezvous/store.h"}},{"before":"882d8091e6c77fc46f7498ff642363df52c38cf7","after":"d1846caab5e4bb1f19da1428fee8e8adb3740d06","ref":"refs/heads/main","pushedAt":"2024-02-18T17:40:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add `[[noreturn]]` to 1 file inc gloo/transport/tcp/pair.cc\n\nSummary: LLVM-15 has a warning `-Wno-return` which can be used to identify functions that do not return. Qualifying these functions with `[[noreturn]]` is a perf optimization.\n\nReviewed By: meyering\n\nDifferential Revision: D53815466\n\nfbshipit-source-id: 02f0b2e4d33ff118c55d285a4e623574c13e378f","shortMessageHtmlLink":"Add <code>[[noreturn]]</code> to 1 file inc gloo/transport/tcp/pair.cc"}},{"before":"90782f947835ae687ceae0f90a18a27132925b96","after":"882d8091e6c77fc46f7498ff642363df52c38cf7","ref":"refs/heads/main","pushedAt":"2024-01-24T20:38:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/alltoallv.cc\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52959036\n\nfbshipit-source-id: ce16eb7d7c260dd85cd2efb4012a94376bd3bd3f","shortMessageHtmlLink":"Fix shadowed variable in gloo/alltoallv.cc"}},{"before":"f5ad225d302dc7dbe721d4e47c5c01ffd56cd0a6","after":"90782f947835ae687ceae0f90a18a27132925b96","ref":"refs/heads/main","pushedAt":"2024-01-24T20:27:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/gatherv.cc\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52959097\n\nfbshipit-source-id: f9f99a8943e1d83e9ee18f17e6a6c0b752a15b24","shortMessageHtmlLink":"Fix shadowed variable in gloo/gatherv.cc"}},{"before":"1e595e42c647b7f958288b2ccc77b85845979bc2","after":"f5ad225d302dc7dbe721d4e47c5c01ffd56cd0a6","ref":"refs/heads/main","pushedAt":"2024-01-24T19:35:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/broadcast.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52959045\n\nfbshipit-source-id: 0133b28882b70f0859f7f0ef8d01b972169070f6","shortMessageHtmlLink":"Fix shadowed variable in gloo/broadcast.h"}},{"before":"563dfa0ef7227b7f19cacb7f5c578f976e5e762c","after":"1e595e42c647b7f958288b2ccc77b85845979bc2","ref":"refs/heads/main","pushedAt":"2024-01-24T19:29:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/gatherv.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52959070\n\nfbshipit-source-id: ebfb98c720df2cc4267fb203877401337268c268","shortMessageHtmlLink":"Fix shadowed variable in gloo/gatherv.h"}},{"before":"9e866dce8db631082fbbec5399befa729dbde7b6","after":"563dfa0ef7227b7f19cacb7f5c578f976e5e762c","ref":"refs/heads/main","pushedAt":"2024-01-24T19:25:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/alltoall.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52959188\n\nfbshipit-source-id: f00f100d79d611fa5e9419f5ad27801b78fccdd7","shortMessageHtmlLink":"Fix shadowed variable in gloo/alltoall.h"}},{"before":"aff690ea112e4e52416c84774003b4e8a15488c6","after":"9e866dce8db631082fbbec5399befa729dbde7b6","ref":"refs/heads/main","pushedAt":"2024-01-23T19:57:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in gloo/test/reduce_scatter_test.cc\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: bunnypak, dmm-fb\n\nDifferential Revision: D53011663\n\nfbshipit-source-id: e7bdca967333e551ca2d38f4b60381eae8681f09","shortMessageHtmlLink":"Remove unused variables in gloo/test/reduce_scatter_test.cc"}},{"before":"43b11158f59d23ef2e9de3c96226a39127274602","after":"aff690ea112e4e52416c84774003b4e8a15488c6","ref":"refs/heads/main","pushedAt":"2024-01-23T19:43:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in gloo/test/transport_test.cc\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: bunnypak, dmm-fb\n\nDifferential Revision: D53011655\n\nfbshipit-source-id: fc7d556051fa9373d4e70d901b7ed5481ca3b29a","shortMessageHtmlLink":"Remove unused variables in gloo/test/transport_test.cc"}},{"before":"c58d3fafb951075dd4ef04a8c679f6b90ed34e7b","after":"43b11158f59d23ef2e9de3c96226a39127274602","ref":"refs/heads/main","pushedAt":"2024-01-23T16:43:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/allgatherv.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52958984\n\nfbshipit-source-id: 380c9be4e3a0acd16e740973101e44878562887b","shortMessageHtmlLink":"Fix shadowed variable in gloo/allgatherv.h"}},{"before":"89abe6758017c0e6cfa0cb7e3a7f94556afb920b","after":"c58d3fafb951075dd4ef04a8c679f6b90ed34e7b","ref":"refs/heads/main","pushedAt":"2024-01-23T16:38:52.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/allgather.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52959003\n\nfbshipit-source-id: 3911d93bed3547220a2335473ccee1130ba4484e","shortMessageHtmlLink":"Fix shadowed variable in gloo/allgather.h"}},{"before":"afc15170120f398f76872e02f766a2d06cd35f3d","after":"89abe6758017c0e6cfa0cb7e3a7f94556afb920b","ref":"refs/heads/main","pushedAt":"2024-01-23T15:33:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add missing isConnected override to uv transport (#381)\n\nSummary:\nProject does not build with -DUSE_LIBUV=ON , due to the introduction of virtual isConnected() in base Pair class. This patch fixes it.\n\nPull Request resolved: https://github.com/facebookincubator/gloo/pull/381\n\nReviewed By: DanilBaibak\n\nDifferential Revision: D53003428\n\nPulled By: malfet\n\nfbshipit-source-id: a406a6fce10d202f06bc2c2ca5f066d6befaf292","shortMessageHtmlLink":"Add missing isConnected override to uv transport (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2095675710\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/gloo/issues/381\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/gloo/pull/381/hovercard\" href=\"https://github.com/facebookincubator/gloo/pull/381\">#381</a>)"}},{"before":"695ab0a6582c9b7c3281537e1ab67494917041f6","after":"afc15170120f398f76872e02f766a2d06cd35f3d","ref":"refs/heads/main","pushedAt":"2024-01-23T07:15:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add some visibility on which rank to rank connections created by Gloo\n\nSummary:\nCreated a starter task for myself to get familiar with Gloo diff work flow. In recent debugging on prod Gloo issues, we found it 'not-so-easy' to answer 1) when\nand how many Gloo PGs are created. 2) For each rank in each PG, how many TCP connections are\nestablished. First adding a simple log at the TCP context layer to expose the rank to rank\nconnectivity during the creation of Full Mesh.\n\nGloo logging seems inconvenient now, thinking we might introduce\nother OSS logging libs in the future\n\nReviewed By: XilunWu\n\nDifferential Revision: D52897536\n\nfbshipit-source-id: c4b78ee7c2a83534c704a55c39766b08d98810f9","shortMessageHtmlLink":"Add some visibility on which rank to rank connections created by Gloo"}},{"before":"772fccfb22d9e974524ed35ebf5fd4c9766ce46a","after":"695ab0a6582c9b7c3281537e1ab67494917041f6","ref":"refs/heads/main","pushedAt":"2024-01-19T03:41:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/transport/context.cc\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52582911\n\nfbshipit-source-id: 498a2fab79c04787c136de65e6ac1e9b154640fa","shortMessageHtmlLink":"Fix shadowed variable in gloo/transport/context.cc"}},{"before":"28d85a49f63e208e0e055500e52fe1ea6ce2e186","after":"772fccfb22d9e974524ed35ebf5fd4c9766ce46a","ref":"refs/heads/main","pushedAt":"2024-01-18T21:27:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in gloo/transport/tcp/pair.cc\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: danzimm, meyering\n\nDifferential Revision: D52848021\n\nfbshipit-source-id: f1e6f1dcf35666ebf3ed45c00602ecea8f0d6b83","shortMessageHtmlLink":"Remove unused variables in gloo/transport/tcp/pair.cc"}},{"before":"6a4f7ed0b8afe54438ac3ab4b205845988e58522","after":"28d85a49f63e208e0e055500e52fe1ea6ce2e186","ref":"refs/heads/main","pushedAt":"2024-01-17T22:50:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in gloo/transport/ibverbs/device.cc\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: danzimm, meyering\n\nDifferential Revision: D52847976\n\nfbshipit-source-id: 6c797d181b3682613c0ab44689461b0515727306","shortMessageHtmlLink":"Remove unused variables in gloo/transport/ibverbs/device.cc"}},{"before":"e6c13da9b2911aa55102488027eeccb74c518322","after":"6a4f7ed0b8afe54438ac3ab4b205845988e58522","ref":"refs/heads/main","pushedAt":"2024-01-17T22:40:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in gloo/rendezvous/redis_store.cc\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: danzimm\n\nDifferential Revision: D52848007\n\nfbshipit-source-id: 58693326dda966d9496635ef292e3a768ea26672","shortMessageHtmlLink":"Remove unused variables in gloo/rendezvous/redis_store.cc"}},{"before":"b03413abcd18188d63c220f5db084c76011e73d1","after":"e6c13da9b2911aa55102488027eeccb74c518322","ref":"refs/heads/main","pushedAt":"2024-01-16T15:39:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/barrier.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D52582817\n\nfbshipit-source-id: f7d7cd3123804c0c11b0f2d38de1b7535cd48e00","shortMessageHtmlLink":"Fix shadowed variable in gloo/barrier.h"}},{"before":"fdca8fba4bf2db3247575214f47a94a868a25a4f","after":"b03413abcd18188d63c220f5db084c76011e73d1","ref":"refs/heads/main","pushedAt":"2024-01-16T15:31:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/context.cc\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D52582807\n\nfbshipit-source-id: 372b0c25139154ded4cc6921facfdbf2f64af869","shortMessageHtmlLink":"Fix shadowed variable in gloo/context.cc"}},{"before":"4b2b39ee49ba824a53d98d5e03f3fa8eb93a11db","after":"fdca8fba4bf2db3247575214f47a94a868a25a4f","ref":"refs/heads/main","pushedAt":"2024-01-16T15:27:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/gather.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D52582850\n\nfbshipit-source-id: d285387f677b4e6800baf6cfed3df146b920d3b2","shortMessageHtmlLink":"Fix shadowed variable in gloo/gather.h"}},{"before":"fb4bbbabb63a9b493109df2cfa47fa512fd95d7b","after":"4b2b39ee49ba824a53d98d5e03f3fa8eb93a11db","ref":"refs/heads/main","pushedAt":"2024-01-16T15:24:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix shadowed variable in gloo/allgatherv.h\n\nSummary:\nOur upcoming compiler upgrade will require us not to have shadowed variables. Such variables have a _high_ bug rate and reduce readability, so we would like to avoid them even if the compiler was not forcing us to do so.\n\nThis codemod attempts to fix an instance of a shadowed variable. Please review with care: if it's failed the result will be a silent bug.\n\n**What's a shadowed variable?**\n\nShadowed variables are variables in an inner scope with the same name as another variable in an outer scope. Having the same name for both variables might be semantically correct, but it can make the code confusing to read! It can also hide subtle bugs.\n\nThis diff fixes such an issue by renaming the variable.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D52582840\n\nfbshipit-source-id: 96890005a4a21a1ce15a9c9fb2dcc3524cefab45","shortMessageHtmlLink":"Fix shadowed variable in gloo/allgatherv.h"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEb9WXVAA","startCursor":null,"endCursor":null}},"title":"Activity · facebookincubator/gloo"}