Add pre-eject message about new features in v2 #5954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gallant-davinci-8f9bd9 ready! Built with commit fbfe366 https://deploy-preview-5954--gallant-davinci-8f9bd9.netlify.com |
|
@iansu is there a way to deploy the docs only if the docs actually changed? Not sure if that's what we want but just throwing it out there. |
Timer
reviewed
Dec 4, 2018
| @@ -38,6 +38,14 @@ function getGitStatus() { | |||
| } | |||
| } | |||
|
|
|||
| console.log( | |||
| chalk.cyan( | |||
| 'NOTE: Create React App 2 supports TypeScript, SASS, CSS Modules and more without ejecting: ' + | |||
There was a problem hiding this comment.
nit: Sass
Suggested change
| 'NOTE: Create React App 2 supports TypeScript, SASS, CSS Modules and more without ejecting: ' + | |
| 'NOTE: Create React App 2 supports TypeScript, Sass, CSS Modules and more without ejecting: ' + |
| @@ -38,6 +38,14 @@ function getGitStatus() { | |||
| } | |||
| } | |||
|
|
|||
| console.log( | |||
| chalk.cyan( | |||
|
@ianschmitz That would be ideal but I don't think it's possible. It adds a bit of noise to non-docs PRs but I don't think it's a big deal. |
Timer
approved these changes
Dec 4, 2018
timsnadden
added a commit
to timsnadden/create-react-app
that referenced
this pull request
Dec 7, 2018
* master: (39 commits) Added extension to .eslintrc (facebook#5988) Update links to docs in all package README files (facebook#5912) Use https for linked images in docs to fix mixed content warnings (facebook#5985) Improve error messaging in verifyPackageTree.js (facebook#5974) Add removeItem to localStorage mock in docs (facebook#5919) Add SASS_PATH instructions to Sass docs (facebook#5917) Suggest a different default for speed reasons (facebook#5959) Add pre-eject message about new features in v2 (facebook#5954) Add netlify.toml to prepare for deploy to netlify facebook#5807 (facebook#5930) Correct some comments (facebook#5927) Add note to docs about using Sass and Flow together (facebook#5823) Update PWA link in README (facebook#5907) Add placeholders to template README for bit.ly links. (facebook#5808) Disable copy to clipboard in cra --info (facebook#5905) Support setupTests.ts (facebook#5698) Remove unnecessary whitespace in template HTML Run prettier on HTML files (facebook#5839) Some Grammar fixes (facebook#5858) Fix link to page about running tests (facebook#5883) fix: make typescriptformatter support 0.5 of fork checker (facebook#5879) ...
mrmckeb
pushed a commit
to BeameryHQ/bmr-react-scripts
that referenced
this pull request
Dec 20, 2018
* Add pre-eject message about new features in v2 * Make message bold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5952