Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why env setting doesn't get applied in the Babel preset #720

Closed
fson opened this issue Sep 23, 2016 · 4 comments
Closed

Investigate why env setting doesn't get applied in the Babel preset #720

fson opened this issue Sep 23, 2016 · 4 comments
Labels
issue: bug tag: underlying tools

Comments

@fson
Copy link
Contributor

fson commented Sep 23, 2016 •
edited
Loading

As mentioned in #716 (comment), the env setting does not apply, unless we merge the settings from the preset manually to our config. It would be good if we could use the preset the same way with the presets option in react-scripts and ejected projects, so I'm going to investigate why this happens.
@fson fson self-assigned this Sep 23, 2016
@fson fson mentioned this issue Sep 23, 2016
Merged
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

It also doesn’t apply after ejecting in #716.
Weeeeird.

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Might be babel/babel#4539.

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Yeah, Babel bug. Will work around it right in the preset for now.

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

I’ll close because not actionable for us, and I don’t care that much about using “real” env syntax because I like to enforce NODE_ENV being present.

@gaearon gaearon closed this as completed Sep 23, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: bug tag: underlying tools
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fson @gaearon