Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openBrowser() causes docker-compose set ups to fail because of spawn EACCESS #711

Merged
merged 2 commits into from
Sep 23, 2016

Conversation

aeneasr
Copy link

@aeneasr aeneasr commented Sep 23, 2016

closes #710

@ghost
Copy link

ghost commented Sep 23, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Sep 23, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 0.5.0 milestone Sep 23, 2016
@gaearon gaearon merged commit 2050174 into facebook:master Sep 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Thanks!

@aeneasr
Copy link
Author

aeneasr commented Sep 23, 2016

Awesome, thanks for merging @gaearon !

@aeneasr aeneasr deleted the patch-1 branch September 23, 2016 10:34
@aeneasr
Copy link
Author

aeneasr commented Sep 23, 2016

@gaearon any chance this could make it in the 0.4.4 release as it's only a bug fix with no bc or other side effects?

@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

I plan to release 0.5.0 today. I likely won't have the time to do two releases today so I hope it won't be too much of an inconvenience to you.

@aeneasr
Copy link
Author

aeneasr commented Sep 23, 2016

Ah awesome! I thought the 0.5.0 release would be some way further down the road because I saw 0.4.3 and 0.4.4 lined up. That will be aboslutely fast enough :)

Thanks for the uber quick responses!

feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
…EACCESS (facebook#711)

* openBrowser() causes docker-compose set ups to fail because of spawn EACCESS - closes facebook#710

Signed-off-by: Aeneas Rekkas (arekkas) <[email protected]>

* Ignore errors
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openBrowser() causes docker-compose set ups to fail because of spawn EACCESS
3 participants