-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency & documentation of which URLs are used #246
Closed
Labels
Comments
cc @ForbesLindesay who also wanted this |
#278 gives us |
We consistently use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We should document and stick to some pattern for what URLs are used, in both the development server and a production deploy.
The rationale is, if you are setting up a proxy, you might want to route a certain path to a different server. You need to choose a path that isn't used by this React app, which means you have to know what paths are used. If you route
/files/*
to a different port, and later we switch the build script so that it generates files prefixed with/files/
, your setup will break.My suggestion is, in production only use the URL patterns
/
and/static/*
. In the dev server, use those two but also/dev/*
for non-static content - ie the websocket. Then any routing layer only has a few things to worry about.The text was updated successfully, but these errors were encountered: