-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles are leaking #1
Comments
I'm just calling SVG Bob, so you should probably reporting this bug to them. |
Maybe that could be namespaced on our end though 🤔 I haven't thought about that, I should try to do that. |
Thanks for considering that! PS: sorry, I did not know, I thought you generated the styles table separately from your JS |
I was also thinking, is it possible to block the style injection from wasm container? It somehow goes in uncontrollable way when the renderer function is called. In principle I could define my own css manually for all rectangles, paths... and then apply for all of them certain classes using regexp or virtual DOM ;D PS: I opened an issue in the original repo, however, the last commit was ~1y ago, I guess, this guy is busy with |
I'm not sure what you mean exactly 🤔 I guess the output string could be transformed somewhat. |
Yeah. You are right. I did not notice, that the string it produces includes all CSSs.
|
solved bob.render ( data ).replace('line, path, circle, rect, polygon', '.frontend-object line, .frontend-object path, .frontend-object circle, .frontend-object rect, .frontend-object polygon'); |
Yo. The maintainer did fix this issue in 0.7 release |
Great job!
![Screenshot 2023-03-21 at 18 16 56](https://user-images.githubusercontent.com/4111822/226689831-2c7c80be-204e-4bcd-b4a2-bb4d1f7512f7.png)
One drawback, that makes me sad - it injects global styles for SVG, which basically corrupts other SVGs on a page.
The text was updated successfully, but these errors were encountered: