feat: implement worker timeout #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This applies the timeout to both the initialization of the plugin and execution of plugin methods. We have to be a little careful about leaving `MessagePort` instances alive in Node. Additionally: accept manifest options in snakeCase and accept memory settings via plugin options. Fixes #74.
It looks like the promise returned by `worker.terminate()` doesn't ref() properly in Bun. We can work around this by keeping a timer alive while we terminate the worker process. However, that reveals that Bun appears not to be able to handle halting Wasm execution in a thread. So -- for now, at least -- disable timeouts in Bun.
mhmd-azeez
approved these changes
Jul 16, 2024
zshipko
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the timeout to both the initialization of the plugin and execution of plugin methods. It turns out that Node was hanging because we were leaving
MessagePortinstances alive; so everywhere we instantiate a worker we race thecreateWorkercall against a timer. If the timer wins, we terminate the worker. This appears to work, even with Wasm running in a tight loop!Additionally: accept manifest options in snakeCase and accept memory settings via plugin options.
Fixes #74.