Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifest.config is not being used #58

Closed
mhmd-azeez opened this issue Mar 19, 2024 · 0 comments · Fixed by #73
Closed

Manifest.config is not being used #58

mhmd-azeez opened this issue Mar 19, 2024 · 0 comments · Fixed by #73
Assignees
@mhmd-azeez

Comments

@mhmd-azeez
Copy link
Collaborator

See:

js-sdk/src/interfaces.ts

Line 277 in 6e4903e

export interface Manifest {

Instead, ExtismPluginOptions.config is being used:

js-sdk/src/interfaces.ts

Line 129 in 6e4903e

export interface ExtismPluginOptions {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhmd-azeez mhmd-azeez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fallback to manifest values if they're not specified in ExtismPluginOptions extism/js-sdk
1 participant
@mhmd-azeez