Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

Setting USE_HUMAN_READABLE_LOG_LEVELS has no effect #444

Closed
jasper-d opened this issue Jul 21, 2020 · 1 comment
Closed

Setting USE_HUMAN_READABLE_LOG_LEVELS has no effect #444

jasper-d opened this issue Jul 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jasper-d
Copy link

jasper-d commented Jul 21, 2020

Repro:

  • Deploy godaddy/kubernetes-external-secrets:4.2.0
  • Set environment variable USE_HUMAN_READABLE_LOG_LEVELS

Expected:
Log levels should use human readable names

Actual:
Log levels are still numeric

deployment.yaml:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: kubernetes-external-secrets
  labels:
    app.kubernetes.io/name: kubernetes-external-secrets
    app.kubernetes.io/instance: kubernetes-external-secrets
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: kubernetes-external-secrets
      app.kubernetes.io/instance: kubernetes-external-secrets
  template:
    metadata:
      labels:
        app.kubernetes.io/name: kubernetes-external-secrets
        app.kubernetes.io/instance: kubernetes-external-secrets
    spec:
      serviceAccountName: external-secrets
      containers:
        - name: kubernetes-external-secrets
          image: "godaddy/kubernetes-external-secrets:4.2.0"
          ports:
          - name: prometheus
            containerPort: 3001
          imagePullPolicy: IfNotPresent
          resources:
            {}
          env:
          - name: "AWS_REGION"
            value: "eu-central-1"
          - name: "GOOGLE_APPLICATION_CREDENTIALS"
            value: "/app/gcp-creds/gcp-creds.json"
          - name: "LOG_LEVEL"
            value: "info"
          - name: "METRICS_PORT"
            value: "3001"
          - name: "POLLER_INTERVAL_MILLISECONDS"
            value: "10000"
          - name: "VAULT_ADDR"
            value: "https://127.0.0.1:8200"
          - name: "USE_HUMAN_READABLE_LOG_LEVELS"
            value: "true"
          # Params for env vars populated from k8s secrets
      securityContext:
        fsGroup: 65534
        runAsNonRoot: true
@Flydiverny Flydiverny added the bug Something isn't working label Jul 21, 2020
@Flydiverny
Copy link
Member

Feature was not included in 4.2.0 but should be available in 5.0.0 release, real changelog here #451

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants