This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
add support for Alibaba Cloud KMS Secret Manager #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with current version only the followings are supported: 1. 'ACSCurrenit' for version stage is the default value and recommented. 2. AccessKeyId + AccessKeySecret or STS (assume a provided role name using the provided AccessKeyId and AccessKeySecret). ECS_RAM_ROLE and Kube2Ram are not supported yet. 3. secret value as plaintext - parsing secret value as a json object not yet support
add support for Alibaba Cloud KMS Secret Manager
The current locked SDK version does not work with STS
|
I have tested locally and in Alibaba Cloud K8s cluster as well. Please review and merge |
ALICLOUD_API_VERSION is not needed
|
@silasbw Could you please kindly review the change. |
Flydiverny
reviewed
May 6, 2020
|
ready for review @Flydiverny |
Flydiverny
approved these changes
May 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with current version only the followings are supported: