-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisStore is required with each limiter #171
Labels
Comments
express-rate-limit/express-rate-limit#364 should help reduce the confusion here. It will make it log an error if the first request is counted more than once with the same store/key/prefix. The error will have a link to https://express-rate-limit.github.io/ERR_ERL_DOUBLE_COUNT/ where we can put a bit of additional information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This not an bug, but just an issue I faced, which will hopefully save somebody hours of work.
For most this is probably already obvious, but you need to create a new
RedisStore
for each limiter.You cannot define a
RedisStore
and then re-use it accross all limiters. This does NOT work:It doesn't work, because
RedisStore
reads thewindowMs
property when initializing, and uses it to setreset-timer
. Without it, thereset-timer
is set by default to 24 hours. Additionally, in the above example theRedisStore
would always use the same keyprefix
, which means that different API routes would count towards the same limit.So in short, you always need to create a new
RedisStore
with each limiter.EXTRA
You can extract the
sendCommand
function to re-use it across all newRedisStores
.The text was updated successfully, but these errors were encountered: