Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when using get_star_position() function #221

Closed
dyahalomi opened this issue Aug 9, 2021 · 2 comments
Closed

Unexpected behavior when using get_star_position() function #221

dyahalomi opened this issue Aug 9, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@dyahalomi
Copy link
Contributor

dyahalomi commented Aug 9, 2021

Describe the bug
I've been trying to use the get_star_position() function to obtain the barycentric position of a star due to orbiting exoplanets. I have been unable to make the get_star_position() function to return any non-zero results.

My planets are an Earth-like and Jupiter-like planet around a Sun-like star. I was able to get non-zero results when using the same orbits and the get_planet_position() function. I also tried increasing the period and mass of the planets in defining the orbits in order to increase the amplitude of the star's orbit, in case it was a rounding error, but also without success.

Perhaps I am misunderstanding something here, and any help would be greatly appreciated!

To Reproduce
See attached file for code (as a .txt file).
test_star_position.txt

Expected behavior
I expected the function to return the barycentric position of the Sun-like star over time (in units of R_sun) due to the sum of the orbits of the Earth-like and Jupiter-like planets.

Your setup (please complete the following information):

  • Version of exoplanet: 0.5.1
  • Operating system: macOS 11.5.1
  • Python version & installation method (pip, conda, etc.): python version 3.9.5. exoplanet and other packages installed with pip.

Additional context

@dyahalomi dyahalomi added the bug Something isn't working label Aug 9, 2021
@dfm
Copy link
Member

dfm commented Aug 10, 2021

The parameter is called m_planet not m_p :D

It would be good to throw an error for unrecognized parameters though!

@dyahalomi
Copy link
Contributor Author

Yeah that fixed it! Sorry for the false alarm and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants