Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get and other methods does not support using host name instead of ip #59

Open
panjacek opened this issue Feb 7, 2019 · 1 comment
Open

Comments

@panjacek
Copy link

panjacek commented Feb 7, 2019

In my test environment IP's might change so I prefer to use host names. Is there a way to get this working without extra layer on my side?

At the moment I am getting:
ValueError: 'server_name.mydomain.local' does not appear to be an IPv4 or IPv6 address

@exhuma
Copy link
Owner

exhuma commented Feb 7, 2019

This was a design-decision. Resolving IP-Addresses can sometimes be non-deterministic (round-robin DNS for example). And I wanted to keep the library free of any such things.

But I have to agree that it would be a nice convenience. And given that socket.gethostbyname('the.hostname') is essentially a no-op for IP-addresses I'm not opposed to adding it.

Should also be a fairly quick change to do as it's only a simple call to add.

I'll add it.

@exhuma exhuma added the v1.x label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants